Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to disable logging #1093

Open
ns-rse opened this issue Feb 21, 2025 · 4 comments
Open

Add the ability to disable logging #1093

ns-rse opened this issue Feb 21, 2025 · 4 comments
Labels

Comments

@ns-rse
Copy link
Collaborator

ns-rse commented Feb 21, 2025

@tdjames1 highlighted that all of the modules include logging such that when used in isolation they produce lots of
.log files.

The entry-point has the ability to run --quiet which reduces output and #929 helped considerably.

It would however be useful to add a --silent argument to suppress all output and ensure that individual modules don't
perform logging when used in isolation.

@ns-rse ns-rse added the logging label Feb 21, 2025
@tdjames1
Copy link

In my use case there is logging output both to stdout and to a log file, with a mix of different styles of log messages.

@ns-rse
Copy link
Collaborator Author

ns-rse commented Feb 24, 2025

Hi @tdjames1 ,

I want to test that what I think is a solution works for your use case. Do you have a code snippet you could share to show how you are using TopoStats please?

@tdjames1
Copy link

Here's a snippet showing the noisy section:

from topostats.io import LoadScans

img_files = [  ... list of paths to .spm files ... ]
load_config = {'channel': 'Height'}

# Load scans
loadscans = LoadScans(img_files, **load_config)
loadscans.get_data()

@tdjames1
Copy link

I've also got calls which use Filters.filter_image() which I think also created a lot of output, but I'm not triggering those atm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants