From 8f9262d93721ad1d119a13cddceb8285a892714d Mon Sep 17 00:00:00 2001 From: Kaosiso Ezealigo Date: Sun, 23 Jun 2024 17:23:42 +0100 Subject: [PATCH] fix(frontend): rows not expanding in evaluation comparison view --- .../pages/evaluations/evaluationCompare/EvaluationCompare.tsx | 2 +- agenta-web/src/services/evaluations/api/index.ts | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/agenta-web/src/components/pages/evaluations/evaluationCompare/EvaluationCompare.tsx b/agenta-web/src/components/pages/evaluations/evaluationCompare/EvaluationCompare.tsx index 0069b9fe0..c3b325c64 100644 --- a/agenta-web/src/components/pages/evaluations/evaluationCompare/EvaluationCompare.tsx +++ b/agenta-web/src/components/pages/evaluations/evaluationCompare/EvaluationCompare.tsx @@ -544,7 +544,7 @@ const EvaluationCompareMode: React.FC = () => { ref={gridRef as any} rowData={rows} columnDefs={colDefs} - getRowId={(params) => params.data.id} + getRowId={(params) => params.data.rowId} headerHeight={64} /> diff --git a/agenta-web/src/services/evaluations/api/index.ts b/agenta-web/src/services/evaluations/api/index.ts index 301bf6c99..98612464d 100644 --- a/agenta-web/src/services/evaluations/api/index.ts +++ b/agenta-web/src/services/evaluations/api/index.ts @@ -14,6 +14,7 @@ import { } from "@/lib/Types" import {getTagColors} from "@/lib/helpers/colors" import {stringToNumberInRange} from "@/lib/helpers/utils" +import {v4 as uuidv4} from "uuid" import exactMatchImg from "@/media/target.png" import similarityImg from "@/media/transparency.png" import regexImg from "@/media/programming.png" @@ -239,6 +240,7 @@ export const fetchAllComparisonResults = async (evaluationIds: string[]) => { rows.push({ id: inputValuesStr, + rowId: uuidv4(), inputs: inputNames .map((name) => ({name, value: data[name]})) .filter((ip) => ip.value !== undefined),