Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated ordering in AmountMath.coerce, getValue, make #3202

Closed
katelynsills opened this issue May 28, 2021 · 0 comments · Fixed by #3892
Closed

Remove deprecated ordering in AmountMath.coerce, getValue, make #3202

katelynsills opened this issue May 28, 2021 · 0 comments · Fixed by #3892
Assignees
@katelynsills
Labels
ERTP package: ERTP

Comments

@katelynsills
Copy link
Contributor

What is the Problem Being Solved?

We changed the order of the parameters for certain functions in AmountMath, and kept the deprecated order. Now, the types for these functions violate the no-implicit-any rule, and users can be confused about which order to use. It would be better to remove the deprecated version.

This gives us a smaller API surface that is more strongly typed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katelynsills katelynsills

Labels
ERTP package: ERTP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ERTP): additional input validation and clean up Agoric/agoric-sdk
1 participant
@katelynsills