Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated Ratio mulitpyBy and divideBy #3676

Closed
4 tasks
Chris-Hibbert opened this issue Aug 13, 2021 · 2 comments · Fixed by #4467
Closed
4 tasks

remove deprecated Ratio mulitpyBy and divideBy #3676

Chris-Hibbert opened this issue Aug 13, 2021 · 2 comments · Fixed by #4467
Assignees
@Chris-Hibbert
Labels
code-style defensive correctness patterns; readability thru consistency devex developer experience enhancement New feature or request hygiene Tidying up around the house Inter-protocol Overarching Inter Protocol technical-debt
Milestone
Mainnet 1 RC0

Comments

@Chris-Hibbert
Copy link
Contributor

Chris-Hibbert commented Aug 13, 2021 •
edited
Loading

What is the Problem Being Solved?

in #3138, we described how to support rounding modes in ratio computations.
#3677 implemented the new functions and deprecated the old. The next step is to remove uses of the old functions and then we'll be able to remove the deprecated functions.

Description of the Design

convert existing contracts to new functions

  • callSpread
  • treasury
  • loan
  • newSwap

Then remove the deprecated functions from ratio.js

Security Considerations

only more reliable calculations

Test Plan

Nothing special.
@Chris-Hibbert Chris-Hibbert added enhancement New feature or request hygiene Tidying up around the house Medium code-style defensive correctness patterns; readability thru consistency technical-debt devex developer experience Inter-protocol Overarching Inter Protocol labels Aug 13, 2021
@Chris-Hibbert Chris-Hibbert added this to the Beta Phase 4: Governance milestone Aug 13, 2021
@Chris-Hibbert Chris-Hibbert self-assigned this Aug 13, 2021
This was referenced Aug 13, 2021
Merged
Merged
@rowgraus rowgraus added the MN-1 label Jan 19, 2022
@Tartuffo
Copy link
Contributor

@Chris-Hibbert After various meetings, this ended up with a MN-1 tag AND in the Product Backlog pipeline (not MN-1 Backlog). Please modify appropriately for what it should actually be.

@Tartuffo
Copy link
Contributor

Tartuffo commented Feb 4, 2022

Only the tests still refer to this. So remove the deprecation and the functions.

@dtribble dtribble mentioned this issue Feb 5, 2022
Merged
@Tartuffo Tartuffo added this to the Mainnet 1 milestone Mar 23, 2022
@Tartuffo Tartuffo modified the milestones: Mainnet 1, RUN Protocol RC0 Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chris-Hibbert Chris-Hibbert

Labels
code-style defensive correctness patterns; readability thru consistency devex developer experience enhancement New feature or request hygiene Tidying up around the house Inter-protocol Overarching Inter Protocol technical-debt
Projects
None yet
Milestone
Mainnet 1 RC0
Development

Successfully merging a pull request may close this issue.

3676 remove deprecated ratio ops Agoric/agoric-sdk
3 participants
@Tartuffo @Chris-Hibbert @rowgraus