Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: dependency versions should not be hardcoded in templates #1835

Closed
vscaiceanu-1a opened this issue May 29, 2024 · 0 comments · Fixed by #1839
Closed

[Bug]: dependency versions should not be hardcoded in templates #1835

vscaiceanu-1a opened this issue May 29, 2024 · 0 comments · Fixed by #1839
Labels
bug Something isn't working priority:medium

Comments

@vscaiceanu-1a
Copy link
Member

Package name

schematics

Package version

10.3.0

Reproduction steps

.

Current result

In packages/@ama-sdk/schematics/schematics/typescript/shell/templates/base/package.json.template, some versions are hardcoded (ex: "@swc/cli": "^0.1.57", "@swc/core": "1.5.7").

Expected result

We should retrieve the versions from a real package.json where the versions are updated regularly.

Additional comments

No response

@vscaiceanu-1a vscaiceanu-1a added bug Something isn't working triage labels May 29, 2024
@kpanot kpanot linked a pull request Jun 5, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants