-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tag.js: in "text equation" there might not be target elements #429
Comments
A quick search showed no other unexpected parents of tag elements -- just |
It seems more transparent to avoid unwrapping target texml-to-html/lib/elements/target.js Lines 14 to 17 in 4da69c3
Then its output would naturally become the target (duh!) and tag would not need to add an ID it never had. However, then we need to prepend target (or make a breaking change and let downstream re-arrange -- which seems unnecessary since we have tags on the left everywhere). |
On a related note, I've filed AmerMathSoc/texml#231 to see if we can move the |
Random thought: a tag without target would also need to be prepended. If we always prepend a tag, could it cause trouble when there's a target? |
I've filed AmerMathSoc/texml#232 in which case we get to simplify this in the future. |
In
https://github.com/AmerMathSoc/ams-xml-to-html/blob/4da69c39d51d15cad31a7becdaf39f59776b5bcc/lib/elements/tag.js#L24
the comment says to assume that each tag has a wrapping target.
However, mcom3734 actually does not.
[Surprisingly, this has not caused issues because instead, the parent is the disp-formula which has an ID and we do not preserve those IDs in HTML.]
The text was updated successfully, but these errors were encountered: