Improvements to footnotes and crossreferences

[tuomas2]

1. to be able to see FootNotes & Refs on a split window alongside Bible (just like a regular hardcopy bible) Footnotes window #2886
2. Also personal NOTES, if possible [already implemented for 4.0]

Other ideas:

• click footnote links to open in a popup / special window etc. [already implemented for 4.0]

[JJK96]

I'm trying to fix this issue, but since I am not very familiar with the codebase yet, I would like to state how I'm trying to approach this first.

So, what I think should be done:

• In writeNoteRef() a link should be returned with a new protocol (as defined in UriAnalyzer.kt).
• This link should be interpreted to open the notes and references view.

Is that approach correct? Or is there a better way?

[JJK96]

When following the above approach, I run into the problem that LinkControl.tk, where the link is handled, has lost the content of the current verse, it would be nice if it is possible to somehow call the VerseMenuCommandHandler.java

[tuomas2]

@JJK96 first of all, welcome to contribute to And Bible :-)

I think you must implement such a link schema that gives the reference to the document, verse, and the order number of footnote you are wanting to display. Then, you can interpret that schema and fetch the footnote from the bible document and display it then in bible view.

[tuomas2]

BTW, If you need to touch java files heavily, please convert them to Kotlin first (in a separate pull request, Android studio does this semi-automatically). I don't want any more java code into codebase :-) Please check also https://github.com/AndBible/and-bible/wiki/Developer-documentation

[tuomas2]

If you drop me email and I can talk to you via hangouts chat too.

[JJK96]

I made a first improvement: f2ae2f8

Clicking a note now opens the "Footnotes and references" activity for the corresponding verse.

It would be nicer if a new window would be opened, but that looks a lot more complex to me, since a new document has to be created.
Anyway, this is a nice first step.