Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window can be partly behind toolbar #641

Closed
JJK96 opened this issue May 3, 2020 · 4 comments
Closed

Window can be partly behind toolbar #641

JJK96 opened this issue May 3, 2020 · 4 comments

Comments

@JJK96
Copy link
Contributor

JJK96 commented May 3, 2020

https://imgur.com/gxFvMpZ

Both windows have the same content and are scrolled all the way up.
It is clear that there is more space between the toolbar and the title in the lower window.

The window size is probably calculated wrongly.

Bug was found on And Bible version
Build 42b6db8

To Reproduce
Steps to reproduce the behavior:

  1. Open two windows
  2. Scroll them to the top
  3. Observe the difference

Expected behavior
Both windows should behave the same.

Smartphone (please complete the following information):

  • Device: Oneplus 6
  • OS: Android
  • Version 10

Additional context
I ran into this issue while working on #188, I can display the notes, but the top part of the text can be hidden behind the toolbar.

@JJK96
Copy link
Contributor Author

JJK96 commented May 3, 2020

This seems to be intentional in order to have nice transitions to fullscreen.

@tuomas2
Copy link
Contributor

tuomas2 commented May 3, 2020

I think it still would be good to prevent split bar from going under toolbar / system bars.

@JJK96 JJK96 closed this as completed May 3, 2020
@tuomas2
Copy link
Contributor

tuomas2 commented May 7, 2020

Indeed this is practically duplicate of #509

@JJK96
Copy link
Contributor Author

JJK96 commented May 7, 2020

Maybe there's a better way to have smooth transition to fullscreen while the main window is not underneath the toolbar.

That would solve this problem, and also #509.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants