Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes: Clicking find while in a note does nothing. #841

Closed
mattschlosser opened this issue Sep 7, 2020 · 4 comments
Closed

Notes: Clicking find while in a note does nothing. #841

mattschlosser opened this issue Sep 7, 2020 · 4 comments

Comments

@mattschlosser
Copy link
Contributor

Describe the bug
Trying to open Find from the menu when a note is open doesn't open Find.

Bug was found on And Bible version
3.389

To Reproduce
Steps to reproduce the behavior:

  1. Open any note
  2. Open Menu and select Find

Expected behavior
Search opens .

Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

  • Device: Pixel 4XL
  • OS: Android 11 Beta 3

Additional context
Add any other context about the problem here.

@timbze
Copy link
Contributor

timbze commented Sep 7, 2020

It was disabled in #703 to prevent crash, but in my opinion a proper fix would be to fix find so that it would search in last active window.

@mattschlosser
Copy link
Contributor Author

mattschlosser commented Sep 7, 2020 via email

@timbze
Copy link
Contributor

timbze commented Sep 7, 2020

That might be a good option. Some of the flow and logic might change with #188 but until then, maybe the back button would be good.

@tuomas2 tuomas2 added this to the v3.4 milestone Sep 8, 2020
@tuomas2
Copy link
Contributor

tuomas2 commented Mar 4, 2021

Tested with current version and searching in my note window is disabled, which is correct behavior until searching is properly implemented (#862). Closing.

@tuomas2 tuomas2 closed this as completed Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants