From 12c497297dcbb02dce9f608b56d86cfc01f6f072 Mon Sep 17 00:00:00 2001 From: Matt Witherspoon <32485495+spoonincode@users.noreply.github.com> Date: Thu, 25 Aug 2022 17:31:16 -0400 Subject: [PATCH 1/3] add a final job that passes if all tests pass --- .github/workflows/build.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index f7861f560f..496e92cb05 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -190,3 +190,10 @@ jobs: with: name: ${{matrix.platform}}-${{matrix.test-name}}-logs path: ${{matrix.platform}}-${{matrix.test-name}}-logs.tar.gz + + all-passing: + name: All Required Tests Passed + needs: [tests, lr-tests, np-tests] + runs-on: ubuntu-latest + steps: + - run: true From 297ab7cffc759fe4490f9f72f36e1cdeedef195e Mon Sep 17 00:00:00 2001 From: Matt Witherspoon <32485495+spoonincode@users.noreply.github.com> Date: Thu, 25 Aug 2022 18:42:31 -0400 Subject: [PATCH 2/3] remove lr-tests from all-passing job --- .github/workflows/build.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 496e92cb05..e715e827af 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -193,7 +193,7 @@ jobs: all-passing: name: All Required Tests Passed - needs: [tests, lr-tests, np-tests] + needs: [tests, np-tests] runs-on: ubuntu-latest steps: - run: true From 25b10298499bf825d590abc3e904693999c9fdc3 Mon Sep 17 00:00:00 2001 From: Matt Witherspoon <32485495+spoonincode@users.noreply.github.com> Date: Thu, 25 Aug 2022 22:13:20 -0400 Subject: [PATCH 3/3] always make the all-passing test bubble up success or fail --- .github/workflows/build.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index e715e827af..c29f2d2ebe 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -194,6 +194,8 @@ jobs: all-passing: name: All Required Tests Passed needs: [tests, np-tests] + if: always() runs-on: ubuntu-latest steps: - - run: true + - if: needs.tests.result != 'success' || needs.np-tests.result != 'success' + run: false