Use consistent name for finality mroot

Author: linh2931

libraries/chain/controller.cpp

@@ -4062,10 +4062,10 @@ struct controller_impl {
 
          // compute finality mroot using previous block state and new qc claim
          auto        computed_finality_mroot = prev.get_finality_mroot_claim(new_qc_claim);
-         const auto& supplied_action_mroot   = b->action_mroot;
-         EOS_ASSERT( computed_finality_mroot == supplied_action_mroot, block_validate_exception,
-                     "computed finality mroot (${computed}) does not match supplied action mroot ${supplied} by header extension. Block number: ${b}, block id: ${id}",
-                     ("computed", computed_finality_mroot)("supplied", supplied_action_mroot)("b", block_num)("id", id) );
+         const auto& supplied_finality_mroot  = b->action_mroot;
+         EOS_ASSERT( computed_finality_mroot == supplied_finality_mroot, block_validate_exception,
+                     "computed finality mroot (${computed}) does not match supplied finality mroot ${supplied} by header extension. Block number: ${b}, block id: ${id}",
+                     ("computed", computed_finality_mroot)("supplied", supplied_finality_mroot)("b", block_num)("id", id) );
       }
 
       return std::optional{qc_proof};

unittests/block_tests.cpp

@@ -441,7 +441,7 @@ BOOST_FIXTURE_TEST_CASE( invalid_action_mroot_test, tester )
                            [] (const fc::exception &e)->bool {
                               return e.code() == block_validate_exception::code_value &&
                                      e.to_detail_string().find("computed finality mroot") != std::string::npos &&
-                                     e.to_detail_string().find("does not match supplied action mroot") != std::string::npos;
+                                     e.to_detail_string().find("does not match supplied finality mroot") != std::string::npos;
                            });
 }