From 6470af3965eeaf53ed1639896ea32d4b728d50d0 Mon Sep 17 00:00:00 2001 From: Jason Botwick Date: Fri, 26 Jan 2024 11:46:42 -0500 Subject: [PATCH 1/3] Fix PipelineNameComparer example in documentation Addresses https://github.com/App-vNext/Polly/issues/1926 In the Complex Pipeline Keys documenation example: https://www.pollydocs.org/advanced/dependency-injection.html#complex-pipeline-keys PipelineNameComparer.GetHashCode takes the InstanceName into account, but shouldn't. This fixes that line in the documentation. --- docs/advanced/dependency-injection.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/advanced/dependency-injection.md b/docs/advanced/dependency-injection.md index f7396cd39a6..4e7496ad04b 100644 --- a/docs/advanced/dependency-injection.md +++ b/docs/advanced/dependency-injection.md @@ -291,7 +291,7 @@ public sealed class PipelineNameComparer : IEqualityComparer { public bool Equals(MyPipelineKey x, MyPipelineKey y) => x.PipelineName == y.PipelineName; - public int GetHashCode(MyPipelineKey obj) => (obj.PipelineName, obj.InstanceName).GetHashCode(); + public int GetHashCode(MyPipelineKey obj) => obj.PipelineName.GetHashCode(); } ``` From e0333c3ba3592300d844ab081f5409894e9e3636 Mon Sep 17 00:00:00 2001 From: Jason Botwick Date: Fri, 26 Jan 2024 12:03:19 -0500 Subject: [PATCH 2/3] Fix PipelineNameComparer example in documentation snippet Addresses https://github.com/App-vNext/Polly/issues/1926 In the Complex Pipeline Keys documenation example: https://www.pollydocs.org/advanced/dependency-injection.html#complex-pipeline-keys PipelineNameComparer.GetHashCode takes the InstanceName into account, but shouldn't. This fixes that line in the documentation. --- src/Snippets/Docs/DependencyInjection.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Snippets/Docs/DependencyInjection.cs b/src/Snippets/Docs/DependencyInjection.cs index 0ed345bdc5a..d756f206968 100644 --- a/src/Snippets/Docs/DependencyInjection.cs +++ b/src/Snippets/Docs/DependencyInjection.cs @@ -225,7 +225,7 @@ public sealed class PipelineNameComparer : IEqualityComparer { public bool Equals(MyPipelineKey x, MyPipelineKey y) => x.PipelineName == y.PipelineName; - public int GetHashCode(MyPipelineKey obj) => (obj.PipelineName, obj.InstanceName).GetHashCode(); + public int GetHashCode(MyPipelineKey obj) => obj.PipelineName.GetHashCode(); } #endregion From 583c3f1c2f9d5000a182f75bdf12dc6886167a74 Mon Sep 17 00:00:00 2001 From: Jason Botwick Date: Fri, 26 Jan 2024 16:52:43 -0500 Subject: [PATCH 3/3] Fix string comparison warning --- src/Snippets/Docs/DependencyInjection.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Snippets/Docs/DependencyInjection.cs b/src/Snippets/Docs/DependencyInjection.cs index d756f206968..5ae5f1c1d19 100644 --- a/src/Snippets/Docs/DependencyInjection.cs +++ b/src/Snippets/Docs/DependencyInjection.cs @@ -225,7 +225,7 @@ public sealed class PipelineNameComparer : IEqualityComparer { public bool Equals(MyPipelineKey x, MyPipelineKey y) => x.PipelineName == y.PipelineName; - public int GetHashCode(MyPipelineKey obj) => obj.PipelineName.GetHashCode(); + public int GetHashCode(MyPipelineKey obj) => obj.PipelineName.GetHashCode(StringComparison.Ordinal); } #endregion