Skip to content

Commit 5ddf078

Browse files
nicoback2nicoback
andauthored
Update SDK version + ActivityFull type (#3819)
Co-authored-by: Nikki Kang <[email protected]>
1 parent c643b8a commit 5ddf078

File tree

13 files changed

+467
-148
lines changed

13 files changed

+467
-148
lines changed

packages/common/package-lock.json

+50-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/common/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"url": "https://github.com/AudiusProject/audius-client/issues"
2929
},
3030
"dependencies": {
31-
"@audius/sdk": "3.0.3-beta.84",
31+
"@audius/sdk": "3.0.3-beta.97",
3232
"@fingerprintjs/fingerprintjs-pro": "3.5.6",
3333
"@metaplex-foundation/mpl-token-metadata": "2.5.2",
3434
"@optimizely/optimizely-sdk": "4.0.0",

packages/common/src/api/developerApps.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ const developerAppsApi = createApi({
101101
const encodedUserId = encodeHashId(userId) as string
102102
const sdk = await audiusSdk()
103103

104-
return await sdk.developerApps.deleteDeveloperApp({
104+
await sdk.developerApps.deleteDeveloperApp({
105105
userId: encodedUserId,
106106
appApiKey: apiKey
107107
})

packages/common/src/services/audius-api-client/ResponseAdapter.ts

+12-7
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,9 @@ import {
2727
APISearch,
2828
APISearchTrack,
2929
APISearchAutocomplete,
30-
APISearchPlaylist
30+
APISearchPlaylist,
31+
APIActivityV2,
32+
isApiActivityV2
3133
} from './types'
3234

3335
export const makeUser = (
@@ -390,13 +392,16 @@ export const makePlaylist = (
390392
}
391393

392394
export const makeActivity = (
393-
activity: APIActivity
395+
activity: APIActivity | APIActivityV2
394396
): UserTrackMetadata | UserCollectionMetadata | undefined => {
395-
switch (activity.item_type) {
396-
case 'track':
397-
return makeTrack(activity.item)
398-
case 'playlist':
399-
return makePlaylist(activity.item)
397+
if (isApiActivityV2(activity)) {
398+
return activity.itemType === 'track'
399+
? makeTrack(activity.item)
400+
: makePlaylist(activity.item)
401+
} else {
402+
return activity.item_type === 'track'
403+
? makeTrack(activity.item)
404+
: makePlaylist(activity.item)
400405
}
401406
}
402407

packages/common/src/services/audius-api-client/types.ts

+11
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,17 @@ export type APIActivity = { timestamp: string } & (
210210
| { item_type: 'playlist'; item: APIPlaylist }
211211
)
212212

213+
export type APIActivityV2 = { timestamp: string } & (
214+
| { itemType: 'track'; item: APITrack }
215+
| { itemType: 'playlist'; item: APIPlaylist }
216+
)
217+
218+
export const isApiActivityV2 = (
219+
activity: APIActivity | APIActivityV2
220+
): activity is APIActivityV2 => {
221+
return (activity as APIActivityV2).itemType !== undefined
222+
}
223+
213224
export type APISearch = {
214225
users?: APIUser[]
215226
followed_users?: APIUser[]

packages/embed/package-lock.json

+66-12
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/embed/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
"webpack-cli": "4.5.0"
3535
},
3636
"dependencies": {
37-
"@audius/sdk": "3.0.3-beta.84",
37+
"@audius/sdk": "3.0.3-beta.97",
3838
"@audius/stems": "1.5.35",
3939
"amplitude-js": "8.11.1",
4040
"axios": "0.19.2",

0 commit comments

Comments
 (0)