Fix tag input (#3832)

amendelsohn · web-flow · commit f6436957ffb0 · 2023-08-01T16:09:02.000-05:00
diff --git a/packages/web/src/components/data-entry/TagInput.js b/packages/web/src/components/data-entry/TagInput.js
@@ -34,11 +34,14 @@ class TagInput extends Component {
 
   newTagInputRef = createRef()
 
-  componentDidUpdate = () => {
+  componentDidUpdate = (prevProps, prevState) => {
     if (this.state.typingMode && this.newTagInputRef.current) {
       this.newTagInputRef.current.focus()
     }
-    if (this.state.tags !== this.props.tags) {
+    if (
+      prevState.tags === this.state.tags &&
+      prevProps.tags !== this.props.tags
+    ) {
       this.setState({ tags: this.props.tags })
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -34,11 +34,14 @@ class TagInput extends Component {`
`34`	`34`
`35`	`35`	`newTagInputRef = createRef()`
`36`	`36`
`37`		`- componentDidUpdate = () => {`
	`37`	`+ componentDidUpdate = (prevProps, prevState) => {`
`38`	`38`	`if (this.state.typingMode && this.newTagInputRef.current) {`
`39`	`39`	`this.newTagInputRef.current.focus()`
`40`	`40`	`}`
`41`		`- if (this.state.tags !== this.props.tags) {`
	`41`	`+ if (`
	`42`	`+ prevState.tags === this.state.tags &&`
	`43`	`+ prevProps.tags !== this.props.tags`
	`44`	`+ ) {`
`42`	`45`	`this.setState({ tags: this.props.tags })`
`43`	`46`	`}`
`44`	`47`	`}`