Skip to content

Commit 83945a6

Browse files
authored
fix(Designer): Update types for experimentation and add a new for value (#5801)
update types
1 parent ae51ec0 commit 83945a6

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import type { IExperimentationService } from '../experimentation';
22

33
export class BaseExperimentationService implements IExperimentationService {
4-
isFeatureEnabled(_featureGateName: string, _type: 'extension' | 'shell') {
4+
isFeatureEnabled(_featureGateName: string, _assignmentType: 'extension' | 'shell') {
55
return Promise.resolve(false);
66
}
77

8-
getFeatureValue(_featureGateName: string, _type: 'extension' | 'shell') {
8+
getFeatureValue(_featureGateName: string, _assignmentType: 'extension' | 'shell', _type: 'string' | 'number' | 'boolean') {
99
return Promise.resolve(undefined);
1010
}
1111
}

libs/logic-apps-shared/src/designer-client-services/lib/experimentation.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import { AssertionException, AssertionErrorCode } from '../../utils/src';
22

33
export interface IExperimentationService {
4-
isFeatureEnabled: (featureGateName: string, type: 'extension' | 'shell') => Promise<boolean>;
4+
isFeatureEnabled: (featureGateName: string, assignmentType: 'extension' | 'shell') => Promise<boolean>;
55
// Setting the return as any since depending on the feature, you can return a string, number or a boolean
6-
getFeatureValue: (featureGateName: string, type: 'extension' | 'shell') => Promise<any>;
6+
getFeatureValue: (featureGateName: string, assignmentType: 'extension' | 'shell', type: 'string' | 'number' | 'boolean') => Promise<any>;
77
}
88

99
let service: IExperimentationService;

0 commit comments

Comments
 (0)