fix(designer): Fix loading indicator while adding new action (#4716)

Co-authored-by: Priti Sambandam <[email protected]>

Author: preetriti1

libs/designer/src/lib/core/actions/bjsworkflow/add.ts

@@ -233,22 +233,9 @@ export const initializeOperationDetails = async (
     addTokensAndVariables(nodeId, type, initData, state, dispatch);
   }
 
-  if (!isConnectionRequired) {
-    updateDynamicDataInNode(
-      nodeId,
-      isTrigger,
-      operationInfo,
-      undefined,
-      initData.nodeDependencies,
-      initData.nodeInputs,
-      initData.settings as Settings,
-      getAllVariables(getState().tokens.variables),
-      dispatch,
-      getState
-    );
-  } else if (connector) {
+  if (isConnectionRequired) {
     try {
-      await trySetDefaultConnectionForNode(nodeId, connector, dispatch, isConnectionRequired);
+      await trySetDefaultConnectionForNode(nodeId, connector as Connector, dispatch, isConnectionRequired);
     } catch (e: any) {
       dispatch(
         updateErrorDetails({
@@ -259,12 +246,25 @@ export const initializeOperationDetails = async (
           },
         })
       );
-      dispatch(setIsPanelLoading(false));
     }
+  } else {
+    updateDynamicDataInNode(
+      nodeId,
+      isTrigger,
+      operationInfo,
+      undefined,
+      initData.nodeDependencies,
+      initData.nodeInputs,
+      initData.settings as Settings,
+      getAllVariables(getState().tokens.variables),
+      dispatch,
+      getState
+    );
   }
 
-  const schemaService = staticResultService.getOperationResultSchema(connectorId, operationId, swagger || parsedManifest);
-  schemaService.then((schema) => {
+  dispatch(setIsPanelLoading(false));
+
+  staticResultService.getOperationResultSchema(connectorId, operationId, swagger || parsedManifest).then((schema) => {
     if (schema) {
       dispatch(addResultSchema({ id: `${connectorId}-${operationId}`, schema: schema }));
     }
@@ -279,7 +279,6 @@ export const initializeOperationDetails = async (
   }
 
   updateAllUpstreamNodes(getState() as RootState, dispatch);
-  dispatch(setIsPanelLoading(false));
 };
 
 export const initializeSwitchCaseFromManifest = async (id: string, manifest: OperationManifest, dispatch: Dispatch): Promise<void> => {

libs/designer/src/lib/ui/panel/panelRoot.tsx

@@ -77,7 +77,7 @@ export const PanelRoot = (props: PanelRootProps): JSX.Element => {
     </div>
   );
 
-  return (!isLoadingPanel && isUndefined(currentPanelMode)) || currentPanelMode === 'Operation' ? (
+  return !isLoadingPanel && (isUndefined(currentPanelMode) || currentPanelMode === 'Operation') ? (
     <NodeDetailsPanel {...commonPanelProps} />
   ) : (
     <Panel