From b8092e91231b76f382274ab8d09aad0e0c449bce Mon Sep 17 00:00:00 2001 From: Krrish Mittal Date: Wed, 2 Oct 2024 16:18:27 -0700 Subject: [PATCH] update types --- .../src/designer-client-services/lib/base/experimentation.ts | 4 ++-- .../src/designer-client-services/lib/experimentation.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libs/logic-apps-shared/src/designer-client-services/lib/base/experimentation.ts b/libs/logic-apps-shared/src/designer-client-services/lib/base/experimentation.ts index 0fc68960e6b..821ac865ad9 100644 --- a/libs/logic-apps-shared/src/designer-client-services/lib/base/experimentation.ts +++ b/libs/logic-apps-shared/src/designer-client-services/lib/base/experimentation.ts @@ -1,11 +1,11 @@ import type { IExperimentationService } from '../experimentation'; export class BaseExperimentationService implements IExperimentationService { - isFeatureEnabled(_featureGateName: string, _type: 'extension' | 'shell') { + isFeatureEnabled(_featureGateName: string, _assignmentType: 'extension' | 'shell') { return Promise.resolve(false); } - getFeatureValue(_featureGateName: string, _type: 'extension' | 'shell') { + getFeatureValue(_featureGateName: string, _assignmentType: 'extension' | 'shell', _type: 'string' | 'number' | 'boolean') { return Promise.resolve(undefined); } } diff --git a/libs/logic-apps-shared/src/designer-client-services/lib/experimentation.ts b/libs/logic-apps-shared/src/designer-client-services/lib/experimentation.ts index bfb5bacd6cf..1ad97abca76 100644 --- a/libs/logic-apps-shared/src/designer-client-services/lib/experimentation.ts +++ b/libs/logic-apps-shared/src/designer-client-services/lib/experimentation.ts @@ -1,9 +1,9 @@ import { AssertionException, AssertionErrorCode } from '../../utils/src'; export interface IExperimentationService { - isFeatureEnabled: (featureGateName: string, type: 'extension' | 'shell') => Promise; + isFeatureEnabled: (featureGateName: string, assignmentType: 'extension' | 'shell') => Promise; // Setting the return as any since depending on the feature, you can return a string, number or a boolean - getFeatureValue: (featureGateName: string, type: 'extension' | 'shell') => Promise; + getFeatureValue: (featureGateName: string, assignmentType: 'extension' | 'shell', type: 'string' | 'number' | 'boolean') => Promise; } let service: IExperimentationService;