Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move parameters and variables to beginning of files in Bicep source #529

Closed
shawngib opened this issue Nov 17, 2021 · 2 comments · Fixed by #563
Closed

Move parameters and variables to beginning of files in Bicep source #529

shawngib opened this issue Nov 17, 2021 · 2 comments · Fixed by #563
Assignees
Labels
bicep Related to Bicep code

Comments

@shawngib
Copy link
Member

shawngib commented Nov 17, 2021

Benefit/Result/Outcome

To make source code a bit more readable on conform to some standards of practice the parameters and variables

Description

In the mlz.bicep main file the parameters and variables start at line 301. When bicep builds the json file for ARM it will host parameters and variable section at the top of the json.

Acceptance Criteria

  • All bicep files run/build with parameters and variables moved to top of files.
  • All bicep files build to supported json not hitting json/ARM limitations:
  • Add parameters descriptors where prudent. @description and potentially @Allowed in cases requiring more control

Additional context: json/ARM Limitations:

4 MB files size (additional 4 MB for parameter file if used)
256 parameters
256 variables
800 resources (including copy count)
64 output values
24,576 characters in a template expression

@shawngib shawngib added needs triage bicep Related to Bicep code labels Nov 17, 2021
@shawngib shawngib added this to the Resource Naming milestone Nov 17, 2021
@shawngib shawngib self-assigned this Nov 17, 2021
@glennmusa
Copy link
Contributor

Since they're moving, would this be a good opportunity to provide @descriptions for each parameter?

@shawngib
Copy link
Member Author

Updated acceptance criteria to reflect the addition @description and @allowed where prudent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bicep Related to Bicep code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants