Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscription APIs should work in disconnect mode #558

Closed
ghost opened this issue Aug 30, 2017 · 0 comments · Fixed by #597
Closed

subscription APIs should work in disconnect mode #558

ghost opened this issue Aug 30, 2017 · 0 comments · Fixed by #597
Labels
Milestone

Comments

@ghost
Copy link

ghost commented Aug 30, 2017

Currently call get_packet(id) in disconnect mode just freezes the script. Pressing Go has no effect. Ideally we could return an empty packet that was subscribed to because subsequent calls will probably be reading that packet. At the very least, Go should skip past the line.

I think this applies even if you're not in disconnect mode. Go and wait don't work at all and Stop has to do a hard kill.

@ghost ghost added the feature label Aug 30, 2017
@ghost ghost closed this as completed in #597 Oct 5, 2017
@ryanmelt ryanmelt added this to the v4.1.0 milestone Nov 20, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant