From 1ea04f828ec04d6d089c9c3a2e6deb3e75f4aeb4 Mon Sep 17 00:00:00 2001 From: Daniel Walsh Date: Sun, 1 Jan 2023 01:25:57 +0000 Subject: [PATCH] Add doubleValue support to OTLP --- .changeset/serious-drinks-decide.md | 5 +++++ src/transformers/otlp.ts | 8 ++++++-- 2 files changed, 11 insertions(+), 2 deletions(-) create mode 100644 .changeset/serious-drinks-decide.md diff --git a/.changeset/serious-drinks-decide.md b/.changeset/serious-drinks-decide.md new file mode 100644 index 0000000..166f5fc --- /dev/null +++ b/.changeset/serious-drinks-decide.md @@ -0,0 +1,5 @@ +--- +"workers-tracing": patch +--- + +Add support for doubleValue to OTLP diff --git a/src/transformers/otlp.ts b/src/transformers/otlp.ts index 07204ca..2da9522 100644 --- a/src/transformers/otlp.ts +++ b/src/transformers/otlp.ts @@ -51,7 +51,7 @@ export interface OtlpValue { stringValue?: string; intValue?: number; boolValue?: boolean; - // TODO: double? + doubleValue?: number; arrayValue?: { values: OtlpValue[] }; } @@ -116,7 +116,11 @@ export class OtlpTransformer extends TraceTransformer { if (typeof value === 'string') { return { stringValue: value }; } else if (typeof value === 'number') { - return { intValue: value }; + if (Number.isInteger(value)) { + return { intValue: value }; + } else { + return { doubleValue: value }; + } } else if (typeof value === 'boolean') { return { boolValue: value }; } else {