Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem: [/currency/x] not possible to propose adding exchanges to a currency #997

Closed
gsovereignty opened this issue Apr 7, 2018 · 25 comments
Labels
Paid-contributor Priority Paid contributors please consider doing this before other issues

Comments

@gsovereignty
Copy link
Member

Problem: it's not possible for users to add exchanges to coins on the currency detail page.

possible solution: Allow users to add an exchange to a currency from the existing list of exchanges or add a new exchange. Ideally this would be a typahead list with "add" if what the user types isn't found (e.g. how Github works with adding branches).

Any solution should also denormalize the data into the currencies collection so that currencies on the home route can be filtered by "is currently listed on an exchange".

@gsovereignty gsovereignty added the Paid-contributor Priority Paid contributors please consider doing this before other issues label Apr 7, 2018
@janat08
Copy link
Collaborator

janat08 commented Apr 7, 2018

All the logic for this is done, except for the add template and some other issues. Notes in last comments of #783.

@samuelralak
Copy link
Member

whats the progress on this one? is anyone actively working on this one?

@gsovereignty
Copy link
Member Author

No, no one has claimed it

@janat08
Copy link
Collaborator

janat08 commented Apr 10, 2018

I think I saw jquery typeahead that was reactive for meteor, that might solve issues.

@gsovereignty
Copy link
Member Author

Can you find it again?

@samuelralak
Copy link
Member

ok cool. can't claim now though but will take a look if its not claimed before finishing my current issues

No, no one has claimed it

@janat08
Copy link
Collaborator

janat08 commented Apr 10, 2018

https://atmospherejs.com/sergeyt/typeahead
I'll take it if we're converting.

@gsovereignty
Copy link
Member Author

Just remember there are no secret updates and no discussions outside of the issue tracker, so what you see here is what you get. If it's not claimed, no one is working on it. And if there are no attached pull requests and no comments, there are no updates ;)

@janat08
Copy link
Collaborator

janat08 commented Apr 10, 2018

It said it supported blaze templates for autocomplete suggestions, but it's likely that the typeahead is outdated and so might not have the empty template option.

@gsovereignty
Copy link
Member Author

@janat08 That looks like the simplest solution :)

@gsovereignty
Copy link
Member Author

If there are any problems with that package and you want to modify it I'll fork it here and C4 it, it looks like there's a good pull request just waiting to be merged but the maintainer is being picky about silly things.

@janat08
Copy link
Collaborator

janat08 commented Apr 10, 2018

Still can't have reactive value since I can't bind an event to typeahead input: sergeyt/meteor-typeahead#161

@janat08
Copy link
Collaborator

janat08 commented Apr 10, 2018

@blockrazorbot claim

@gsovereignty
Copy link
Member Author

@janat08 can you remind me, what's the problem with the existing typeahead?

@janat08
Copy link
Collaborator

janat08 commented Apr 12, 2018

I couldn't pass in a event or reflect current value of typeahead in empty template.

@gsovereignty
Copy link
Member Author

in empty template.

Can you explain more here, a template referring to an empty data set?

@janat08
Copy link
Collaborator

janat08 commented Apr 12, 2018

empty result set, prompting to make a new result.

@gsovereignty
Copy link
Member Author

OK. I don't know how far along you are with this, but a simpler solution will be to just add a "add new" button next to the typeahead dropdown (similar to /add-hashpower).

@janat08
Copy link
Collaborator

janat08 commented Apr 12, 2018

The package is in place, it's the fact that I can't select typeahead element or update the value aside. The typeahead('val') will work, it's more about other options I like custom events and updating the value for reactivity.

@gsovereignty
Copy link
Member Author

OK. Stay focussed on the problem. This solution is probably too complicated and not worth it.

If you have to make something work in an hour and close this issue what would you do?

@janat08
Copy link
Collaborator

janat08 commented Apr 12, 2018

Ideally this would be a typahead list with "add" if what the user types isn't found (e.g. how Github works with adding branches).
Do you want a separate button? If element selection were to work it wouldn't take over an hour to finish.

@gsovereignty
Copy link
Member Author

Oh ok, well element selection would be better :)

@janat08
Copy link
Collaborator

janat08 commented Apr 12, 2018

I'm just waiting for someone to respond to sergeyt/meteor-typeahead#161 though.

@gsovereignty
Copy link
Member Author

It's safe to say no one is going to respond. So just do whatever the simplest thing is to close this off.

@gsovereignty
Copy link
Member Author

Closed and moved to #1236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paid-contributor Priority Paid contributors please consider doing this before other issues
Projects
None yet
Development

No branches or pull requests

4 participants