-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
problem: [/currency/x] not possible to propose adding exchanges to a currency #997
Comments
All the logic for this is done, except for the add template and some other issues. Notes in last comments of #783. |
whats the progress on this one? is anyone actively working on this one? |
No, no one has claimed it |
I think I saw jquery typeahead that was reactive for meteor, that might solve issues. |
Can you find it again? |
ok cool. can't claim now though but will take a look if its not claimed before finishing my current issues
|
https://atmospherejs.com/sergeyt/typeahead |
Just remember there are no secret updates and no discussions outside of the issue tracker, so what you see here is what you get. If it's not claimed, no one is working on it. And if there are no attached pull requests and no comments, there are no updates ;) |
It said it supported blaze templates for autocomplete suggestions, but it's likely that the typeahead is outdated and so might not have the empty template option. |
@janat08 That looks like the simplest solution :) |
If there are any problems with that package and you want to modify it I'll fork it here and C4 it, it looks like there's a good pull request just waiting to be merged but the maintainer is being picky about silly things. |
Still can't have reactive value since I can't bind an event to typeahead input: sergeyt/meteor-typeahead#161 |
@blockrazorbot claim |
@janat08 can you remind me, what's the problem with the existing typeahead? |
I couldn't pass in a event or reflect current value of typeahead in empty template. |
Can you explain more here, a template referring to an empty data set? |
empty result set, prompting to make a new result. |
OK. I don't know how far along you are with this, but a simpler solution will be to just add a "add new" button next to the typeahead dropdown (similar to /add-hashpower). |
The package is in place, it's the fact that I can't select typeahead element or update the value aside. The typeahead('val') will work, it's more about other options I like custom events and updating the value for reactivity. |
OK. Stay focussed on the problem. This solution is probably too complicated and not worth it. If you have to make something work in an hour and close this issue what would you do? |
|
Oh ok, well element selection would be better :) |
I'm just waiting for someone to respond to sergeyt/meteor-typeahead#161 though. |
It's safe to say no one is going to respond. So just do whatever the simplest thing is to close this off. |
Closed and moved to #1236 |
Problem: it's not possible for users to add exchanges to coins on the currency detail page.
possible solution: Allow users to add an exchange to a currency from the existing list of exchanges or add a new exchange. Ideally this would be a typahead list with "add" if what the user types isn't found (e.g. how Github works with adding branches).
Any solution should also denormalize the data into the currencies collection so that currencies on the home route can be filtered by "is currently listed on an exchange".
The text was updated successfully, but these errors were encountered: