Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOVERSION bump #581

Closed
avalentino opened this issue Feb 1, 2024 · 3 comments
Closed

SOVERSION bump #581

avalentino opened this issue Feb 1, 2024 · 3 comments

Comments

@avalentino
Copy link
Member

avalentino commented Feb 1, 2024

Describe the bug

In c-blosc2 2.13.0 the register_tuner_private symbol has been renamed into blosc2_register_tuner.
From the name I understand that it is supposed to be a function part of the private API, never the less it is exported via BLOSC_EXPORT so it is part of the API.

I think that the SOVERSION in blosc/CMakeLists.txt should be bumped to 3 for c-blosc2 2.13.x

set_target_properties(blosc2_shared PROPERTIES
VERSION ${version_string}
SOVERSION 2 # Change this when an ABI change happens
)

To Reproduce
N/A

Expected behavior
SOVERSION updated when the API changes

Logs
N/A

System information:

  • OS: Linux/Unix
  • Version blosc2 2.13.x

Additional context
N/A

@avalentino avalentino changed the title SEVERSION bump SOVERSION bump Feb 1, 2024
@avalentino
Copy link
Member Author

Hi @FrancescAlted I have started preparing the upload in debian of c-blosc2 2.12.x.

I would need to bumb the soversion because of the above change (in debian we use strict symbol control).

I could do it with a debian specific patch but I would like to avoid going out of sync with the versioning of the upstream c-blosc2 library.

What is the plan for this issue?

@FrancescAlted
Copy link
Member

Yes, we had to change the API to make it more consistent. I am sorry that we are not very careful about bumping SOVERSION accordingly. Fixed in 1d9eb59

I don't know when we can produce a new release, but asap. Thanks for the reminder anyway!

@avalentino
Copy link
Member Author

Thanks a lot Francesc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants