Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note about why Clippy doesn't do this? #78

Closed
tombh opened this issue Aug 20, 2024 · 2 comments
Closed

Add a note about why Clippy doesn't do this? #78

tombh opened this issue Aug 20, 2024 · 2 comments

Comments

@tombh
Copy link

tombh commented Aug 20, 2024

Thanks for this crate, it worked first time, removing 9 deps! ❤️

I chose yours over the others (machete, udeps, etc) because of the comparison section in the README. I wonder if it might also be useful to add a few lines explaining why such a crate is necessary? I was surprised that such functionality isn't already supported in Clippy for example. There are issues like these; rust-lang/rust#57274, rust-lang/rust-clippy#4341, that track this.

Seeing at a glance both the other available projects and the reasons why these projects exist would be a nice way of helping to make a quick and informed decision to install this particular project (which also gave me a six-pack and restored my 20/20 vision).

@Boshen
Copy link
Owner

Boshen commented Aug 21, 2024

These projects were created one after another with years apart, each improving the existing one when cargo added more features. cargo workspaces is a fairly "new" feature 😅

Clippy doesn't have project-wide analysis I think, you need to go through some hoops to get the workspace data you need ...

@Boshen Boshen closed this as completed in 92e6bf6 Aug 21, 2024
@tombh
Copy link
Author

tombh commented Aug 21, 2024

Thanks for the context and update 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants