Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Cloud Events in Transports #3532

Open
iancooper opened this issue Feb 26, 2025 · 2 comments
Open

Support Cloud Events in Transports #3532

iancooper opened this issue Feb 26, 2025 · 2 comments
Assignees
Labels
2 - In Progress feature request .NET Pull requests that update .net code RC1 v10 Allocal to a v10 release

Comments

@iancooper
Copy link
Member

Is your feature request related to a problem? Please describe.
We have a transformer for CloudEvents: Paramore.Brighter.Transforms.Transformers.CloudEventsTransformer, that is invoked if you use the [CloudEvents attribute] but have not implemented in default mappers and transports

Describe the solution you'd like

  • It is not applied on the default mapper: Paramore.Brighter.MessageMappers.JsonMessageMapper<> and it should be
  • Each transport needs code, to take the Cloud Events headers from the Brighter Message Headers, and write them to the native message format, according to that transport's implementation of Cloud Events.
  • We should also read Cloud Events headers back out from transports, and populate the relevant message headers (these are accessible to a request now, because the RequestContext includes the original message in V10)
@iancooper iancooper added 0 - Backlog feature request v10 Allocal to a v10 release .NET Pull requests that update .net code labels Feb 26, 2025
@iancooper
Copy link
Member Author

In addition, we should ensure that the W3C TraceContext headers are being set correctly. This may be happening if the transport supports Open Telemetry

@iancooper
Copy link
Member Author

See #3551

@iancooper iancooper added the RC1 label Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In Progress feature request .NET Pull requests that update .net code RC1 v10 Allocal to a v10 release
Projects
None yet
Development

No branches or pull requests

2 participants