-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support all network configs #6351
Comments
To get a better overview of what's missing we need to add
The following constants are missing right now
|
This will be (partially) addressed by #7294 |
@wemeetagain I started tracking those here, we've added a bunch for electra fork since those changed but I think this is rather low prio to add all of them unless there is demand for it |
After reviewing the spec values I noticed we are still missing plenty of network values which should be part of the config (configs/mainnet.yaml#L113-L150). We either don't support them or those are defined as constants.
I looked into refactoring this to move all of the constants into config but not all parts of the code that use those values can get access to configs easily, for example values used in
rateLimitQuotas
lodestar/packages/beacon-node/src/network/reqresp/rateLimit.ts
Line 11 in 2db7120
While it should be possible to refactor the code to make this work, I think we should avoid large changes before the Deneb hard fork as current configuration is well tested already and there is no specific requirements to move those values from constants to config.
From #6328
The text was updated successfully, but these errors were encountered: