Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modification of agent version for Lodestar #200

Closed
philknows opened this issue Sep 9, 2022 · 2 comments
Closed

Modification of agent version for Lodestar #200

philknows opened this issue Sep 9, 2022 · 2 comments

Comments

@philknows
Copy link
Member

Background

Details

Reference: ChainSafe/lodestar#4465

Lodestar is looking to modify the agent version gossiped from the default libp2p string js-libp2p/0.36.2 to lodestar/version. We are requesting an update to your client on how you identify Lodestar nodes for better tracking and referencing of Lodestar peers on the network for debug purposes. We will not implement until it has been completed between all the various clients on the network.

Acceptance criteria

Update crawler with how it identifies Lodestar on the network. Should detect Lodestar under lodestar/version.

@spacesailor24
Copy link
Contributor

From my understanding, no code change is required for how the crawler parses the UserAgent. This line splits the UserAgent into it's parts based off of /, so if Lodestar's UserAgent is Lodestar/0.41.0, we'd be storing the Peer with userAgent.Name = Lodestar and userAgent.version = 0.41.0

@sadiq1971
Copy link
Member

From my understanding, no code change is required for how the crawler parses the UserAgent. This line splits the UserAgent into it's parts based off of /, so if Lodestar's UserAgent is Lodestar/0.41.0, we'd be storing the Peer with userAgent.Name = Lodestar and userAgent.version = 0.41.0

Right. Nothing required. I already tested this and Lodestar client was being parsed successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants