Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test files: remove obsolete eslint comments that set mocha / node env #1339

Open
florian-sanders-cc opened this issue Feb 18, 2025 · 0 comments
Open

test files: remove obsolete eslint comments that set mocha / node env #1339

florian-sanders-cc opened this issue Feb 18, 2025 · 0 comments
Labels
easy-quick-win maintenance Code refactoring, project structure, dev tooling (storybook, dev server, npm tasks...)

Comments

@florian-sanders-cc
Copy link
Contributor

Context

Since we've moved to ESLint 9 & flat config, we no longer need comments to set the eslint environment.
The /* eslint-env node, mocha */ comments should be removed from all test files.

If new errors arise after removing these comments, then it means the related file should be added in the proper section of the eslint.config.js file.
@florian-sanders-cc florian-sanders-cc added easy-quick-win maintenance Code refactoring, project structure, dev tooling (storybook, dev server, npm tasks...) labels Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy-quick-win maintenance Code refactoring, project structure, dev tooling (storybook, dev server, npm tasks...)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@florian-sanders-cc