From e4170133b6e8e64a081c3d1cb769220d2b4acac9 Mon Sep 17 00:00:00 2001
From: Charles Kawczynski <kawczynski.charles@gmail.com>
Date: Sun, 9 Mar 2025 13:57:12 -0400
Subject: [PATCH] Add convenience method in stencils (#2221)

---
 src/Operators/finitedifference.jl | 29 +++++++++++++++++++++++------
 1 file changed, 23 insertions(+), 6 deletions(-)

diff --git a/src/Operators/finitedifference.jl b/src/Operators/finitedifference.jl
index 1555dc214e..c0a37a3d41 100644
--- a/src/Operators/finitedifference.jl
+++ b/src/Operators/finitedifference.jl
@@ -3739,6 +3739,27 @@ end
     right_idx(space)
 end
 
+@inline function should_call_left_boundary(idx, space, bc, loc)
+    (; op) = bc
+    return Operators.has_boundary(op, loc) &&
+           idx < Operators.left_interior_idx(
+        space,
+        op,
+        Operators.get_boundary(op, loc),
+        bc.args...,
+    )
+end
+
+@inline function should_call_right_boundary(idx, space, bc, loc)
+    (; op) = bc
+    return Operators.has_boundary(op, loc) &&
+           idx > Operators.right_interior_idx(
+        space,
+        bc.op,
+        Operators.get_boundary(bc.op, loc),
+        bc.args...,
+    )
+end
 
 Base.@propagate_inbounds function getidx(
     parent_space,
@@ -3760,9 +3781,7 @@ Base.@propagate_inbounds function getidx(
 )
     space = reconstruct_placeholder_space(axes(bc), parent_space)
     op = bc.op
-    if has_boundary(op, loc) &&
-       idx <
-       left_interior_idx(space, bc.op, get_boundary(bc.op, loc), bc.args...)
+    if should_call_left_boundary(idx, space, bc, loc)
         stencil_left_boundary(
             op,
             get_boundary(op, loc),
@@ -3787,9 +3806,7 @@ Base.@propagate_inbounds function getidx(
 )
     op = bc.op
     space = reconstruct_placeholder_space(axes(bc), parent_space)
-    if has_boundary(op, loc) &&
-       idx >
-       right_interior_idx(space, bc.op, get_boundary(bc.op, loc), bc.args...)
+    if should_call_right_boundary(idx, space, bc, loc)
         stencil_right_boundary(
             op,
             get_boundary(op, loc),