Skip to content

Commit 91e77f1

Browse files
committed
fix: live rendering error boundary around bad comments
1 parent 953bb21 commit 91e77f1

File tree

1 file changed

+2
-2
lines changed
  • javascript-modules/live/lib/app

1 file changed

+2
-2
lines changed

javascript-modules/live/lib/app/core.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ const evaluateTemplate = async (liveInstance, documentNode, parentPathStack, tem
108108

109109
for (const [name, identifier] of parseParams(contextMatches?.groups["context"])) {
110110
// TODO: This shouldn't be required post-tokenizer
111-
if (!identifier) return;
111+
if (!identifier) continue;
112112
// TODO: bindings here has no encapsulation / stack, which feels too SSG-coupled for assigns
113113
// TODO: bindings here has no encapsulation / stack, which is wrong for loops
114114
bindings[name] = await liveInstance.eval(identifier, combinedScope());
@@ -125,7 +125,7 @@ const evaluateTemplate = async (liveInstance, documentNode, parentPathStack, tem
125125
pathStack.push({});
126126
for (const [name, identifier] of params) {
127127
// TODO: This shouldn't be required post-tokenizer
128-
if (!identifier) return;
128+
if (!identifier) continue;
129129
if (name === 'bind') {
130130
const bindVals = await liveInstance.eval(identifier, combinedScope());
131131
if (bindVals && typeof bindVals === 'object') {

0 commit comments

Comments
 (0)