-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Add All Artists on Track Into Artist Tag Separated by ; including featured artists #39
Comments
It is a HUGE problem of Qobuz itself! Just compare lists of track artists in releases on Qobuz & on Deezer: Judge Jules - Hold On : QobuzDownloaderX-MOD can't take artist info from nowhere. If information about the track artist is missing in qobuz itself, then it will be missing in QobuzDownloaderX-MOD. I aownloaded thiese 2 releases in doubledouble.top, there are multitag present, it better, but track artist must be correctly as in deezer. Ex: Judge Jules & Roger Shah feat. Amanda Angelic NOT Judge Jules \\ Roger Shah \\ Amanda Angelic. Deezer has multitag artists (not artist). Also deezer supports alternative languages: |
If the info isn't in Qobuz's API result, I can't get it either. I checked the given track from doubledouble.top and It seems they just take the entire list of "performers" and dump their roles, as returned by the Qobuz API, in separate ID3 / VORBIS tags and hope for the best. For example, https://play.qobuz.com/track/219736471 Credits displayed in Qobuz webplayer (and returned as such in the API result): Resulting garbage tags returned by doubledouble.top's method: The method used by double double results in garbage tags like "LLC/UNIVERSAL MUSIC PUBLISHING INC" = "Nasir Jones (Sun Shining". (because they just split the roles by ",", there isn't any other way) The entire list I will probably just dump in the INVOLVEDPEOPLE tag so the user can rearrange them to their heart's content... |
After extensive testing, there doesn't really seems to be an ideal solution, given the unreliable info present in the Qobuz Library.
Example album given was https://play.qobuz.com/album/zfig6airc2ubc For Album:
For 1st Track (01 - Mediterraneo (Club Mix)):
To be continued for a decision... |
Since there was no ideal solution, I settled on the following "solution". New settings
AlbumArtistInstead of using the Album.Artist.Name returned by the Qobuz API by default, now all Album.Artists returned by the Qobuz API are gathered and a list of "Album.Artist.Name"s is used instead.
TrackArtist (Artist)Instead of using the Track.Performer.Name returned by the Qobuz API by default, now the complete Track.Performers string, returned by the Qobuz API, is parsed (best effort) into a list of Performers and their respective roles.
ComposerFrom the parsed Track.Performers string, the Performers with the Composer role are collected into a list of Composers.
ProducerFrom the parsed Track.Performers string, the Performers with the Producer role are collected into a list of Producers.
|
🚀 Feature Request
Is your feature request related to a problem? Please describe.
If an album doesn't have the artist in the title of the track on qobuz like (feat. artist) then it will be missing from the tags completely. I'll have to manually add each featured artist.
*
Describe the solution you'd like
If you can just grab all artists per track with api from MainArtist and also FeaturedArtist and then separate each artist by semicolon it would be perfect in the tags. Example, Nas; 21 Savage; Nelly if the track had 3 artists. Thats how it should look in the artist name field.
*
Describe alternatives you've considered
Only doubledouble.top has artists correctly. All others i've tried are missing artist info if not in the title of the track. Not sure how doubledouble figured it out, but that is very nice.
*
Additional context
Nas - Magic 2 album, the last track one mic one gun, doesn't have 21 savage in the tags. But on Qobuz, 21 savage would be listed as featured artist. If you could just put all artists into artist name field from there, it would fix this issue.
*
The text was updated successfully, but these errors were encountered: