Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Request: Feature flag to disable deletion of Disruption #497

Closed
nikos912000 opened this issue Feb 7, 2022 · 3 comments · Fixed by #499
Closed

User Request: Feature flag to disable deletion of Disruption #497

nikos912000 opened this issue Feb 7, 2022 · 3 comments · Fixed by #499

Comments

@nikos912000
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Our team is working on integrating the chaos controller with our CI/CD platform.

The setup we have is as follows:

  • Kubefed acts as the control plane and propagates any changes to worker clusters.
  • Worker clusters are the ones where workloads get deployed. These are the clusters where we run Disruptions.
  • The Spinnaker pipeline deploys Disruptions to the worker clusters through Kubefed.

Right now the deletion of Disruptions is done by the controller. This is happening once the Disruption expires and after the GC period.
This is great, but with a control plane we tend to have kubefed handling the lifecycle of any resources deployed to worker clusters. Ideally the responsibility to delete Disruptions would be on Spinnaker and Kubefed.

Describe the solution you'd like
Introduce a toggle in the controller's ConfigMap which disables the deletion.

Describe alternatives you've considered
The other option for us is to set the GC to a very large value so Spinnaker/Kubefed are always the first ones to do the deletion.

Additional context
Let us know if you have any other ideas. If this can be solved in a different way happy to consider it!

@ptnapoleon
Copy link
Contributor

Absolutely, happy to add this

@nikos912000
Copy link
Contributor Author

Awesome, thank you.
Is it just checking this flag in here?
Happy to raise the PR.

@ptnapoleon
Copy link
Contributor

Yes, more or less. I will have a PR for you to review today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants