[NDM][Cisco SD-WAN] Make sure to copy device tags (#34939)

Author: TCheruy

pkg/collector/corechecks/network-devices/cisco-sdwan/payload/devices.go

@@ -34,8 +34,7 @@ func GetDevicesMetadata(namespace string, devices []client.Device) []devicemetad
 func GetDevicesTags(namespace string, devices []client.Device) map[string][]string {
 	deviceTags := make(map[string][]string)
 	for _, device := range devices {
-		deviceTags[device.SystemIP] = buildDeviceTags(namespace, device)
-		deviceTags[device.SystemIP] = append(deviceTags[device.SystemIP], fmt.Sprintf("%s:%s", DeviceUserTagResourcePrefix, buildDeviceID(namespace, device)))
+		deviceTags[device.SystemIP] = append(buildDeviceTags(namespace, device), fmt.Sprintf("%s:%s", DeviceUserTagResourcePrefix, buildDeviceID(namespace, device)))
 	}
 	return deviceTags
 }

pkg/collector/corechecks/network-devices/cisco-sdwan/report/metrics.go

@@ -15,6 +15,7 @@ import (
 	"github.com/DataDog/datadog-agent/pkg/aggregator/sender"
 	"github.com/DataDog/datadog-agent/pkg/collector/corechecks/network-devices/cisco-sdwan/client"
 	"github.com/DataDog/datadog-agent/pkg/collector/corechecks/network-devices/cisco-sdwan/payload"
+	"github.com/DataDog/datadog-agent/pkg/networkdevice/utils"
 	"github.com/DataDog/datadog-agent/pkg/util/log"
 )
 
@@ -369,7 +370,7 @@ func (ms *SDWanSender) getDeviceTags(systemIP string) []string {
 	if !ok {
 		return []string{"system_ip:" + systemIP}
 	}
-	return tags
+	return utils.CopyStrings(tags)
 }
 
 func (ms *SDWanSender) getPrefixedDeviceTags(prefix string, systemIP string) []string {

releasenotes/notes/fix-cisco-sdwan-tags-b00731cd2f169370.yaml

@@ -0,0 +1,11 @@
+# Each section from every release note are combined when the
+# CHANGELOG.rst is rendered. So the text needs to be worded so that
+# it does not depend on any information only available in another
+# section. This may mean repeating some details, but each section
+# must be readable independently of the other.
+#
+# Each section note must be formatted as reStructuredText.
+---
+fixes:
+  - |
+    Cisco SD-WAN: fix an issue that could lead to incorrect metrics tagging.