Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis issue #1205

Closed
jostster opened this issue Mar 10, 2023 · 4 comments · Fixed by #1220
Closed

Analysis issue #1205

jostster opened this issue Mar 10, 2023 · 4 comments · Fixed by #1220
Assignees
Labels
compilation issue SDK doesn't compile or gives warnings.

Comments

@jostster
Copy link

The issue

When running Analyze on Xcode Cloud we get
file:///Volumes/workspace/DerivedData/SourcePackages/checkouts/dd-sdk-ios/Sources/_Datadog_Private/ObjcAppLaunchHandler.m:44
Value stored to 'token' during its initialization is never read.

This prevents our analyze checks from passing.


Datadog SDK version:

1.16

Last working Datadog SDK version:

N/A

Dependency Manager:

SPM

Other toolset:

N/A

Xcode version:

Xcode 14.2

Swift version:

5.7

Deployment Target:

iOS 15+

macOS version:

13.2.1

@jostster jostster added the compilation issue SDK doesn't compile or gives warnings. label Mar 10, 2023
@maxep
Copy link
Member

maxep commented Mar 13, 2023

Hi @jostster 👋

This token is there for retaining the observer until completion.
We could add a pragma to silence this warning #pragma unused(token) in our code, but in the meantime you can set the GCC_WARN_UNUSED_VARIABLE flag to NO in your build config.

@maxep maxep self-assigned this Mar 13, 2023
@jostster
Copy link
Author

@maxep Thanks for the reply. I might need to wait until a fix is deployed as this would disable our CI checks for the entire project.

@jostster
Copy link
Author

Just checking in @maxep . We are unable to implement datadog into our app because the PR will not pass the analyze phase.

@maxep
Copy link
Member

maxep commented Mar 22, 2023

Hey @jostster 👋

I've just opened a PR, it will be part of our next release.

@maciejburda maciejburda mentioned this issue Mar 23, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compilation issue SDK doesn't compile or gives warnings.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants