Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the PHPStan ResultsParser so any errors reported by PHPStan stop SARB from running #135

Closed
DaveLiddament opened this issue Jan 9, 2024 · 1 comment
Closed

Update the PHPStan ResultsParser so any errors reported by PHPStan stop SARB from running #135

DaveLiddament opened this issue Jan 9, 2024 · 1 comment

Comments

@DaveLiddament
Copy link
Owner

PHPStan reports errors and issues. SARB is only interested in issues. However if there are and errors, this means PHPStan might not have completed its analysis correctly. As SARB swallows the errors problems could be missed.

If PHPStan reports an error then SARB should report these errors to the end user and stop.
This was referenced Jan 9, 2024
Closed
Merged
@DaveLiddament
Copy link
Owner Author

Fixed by #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DaveLiddament