Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing JSON export #197

Closed
nstbayless opened this issue Mar 19, 2023 · 3 comments · Fixed by #199
Closed

Missing JSON export #197

nstbayless opened this issue Mar 19, 2023 · 3 comments · Fixed by #199

Comments

@nstbayless
Copy link
Contributor

Unless I'm mistaken, Dn-Famitracker does not have JSON export, which is a feature in 0CC-Famitracker. Here are side-by-side screenshots of Dn-Famitracker and 0CC-Famitracker:

image

JSON export is a very handy feature because it's easily parsable by scripts. This facilitates, for example, converting a famitracker module into an engine-specific format.

@Gumball2415
Copy link
Collaborator

Dn-FT is based on 0CC version 0.3.14.5. the last release of 0CC (version 0.3.15.3) has left the codebase in a somewhat incompatible state. more effort will be required to port JSON export into Dn-FT.

@nstbayless
Copy link
Contributor Author

I could work on a pull request that offers support for this feature. I'd like to confirm first, however, that this won't be rejected simply because the JSON export feature is for some reason undesirable.

@Gumball2415
Copy link
Collaborator

i wouldn't mind feature parity with the last known 0CC dev build really, so i'm not against such a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants