Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New *.nsf-export algorithm question/bug? #242

Closed
eugene-s-nesdev opened this issue Nov 19, 2023 · 9 comments · Fixed by #214
Closed

New *.nsf-export algorithm question/bug? #242

eugene-s-nesdev opened this issue Nov 19, 2023 · 9 comments · Fixed by #214

Comments

@eugene-s-nesdev
Copy link

Hi! I need to ask you about new NSF-export algorithm, maybe you can help me.

Classic versions of Famitracker and 0cc-Famitracker generate standart *.nsf-file, NTSC-headered.
If you play it on emulator in PAL or Dendy mode - tempo will slowing down, and this is absolutely normal.

But new version of DN-famitracker does something strange.
It also generates standard.nsf-file, NTSC headered, but it:

  • plays same tempo on NTSC/PAL/Dendy (Mesen)
  • have old-style behavior described above (nestopia, fceux)
  • crackling on puNES emulator at PAL/Dendy.

Maybe you know what's really happened in the new NSF-export algorhitms or it's general DN-Famitracker bug?
nsf_test.zip

@Gumball2415
Copy link
Collaborator

Gumball2415 commented Nov 19, 2023

as of this time of writing, no version of FT or any FT fork supports Dendy mode.

can you clarify whether your exported NSFs are NTSC-headered or Dual region headered? FT has options to export NTSC, PAL, or both, with the NSF player discerning which one to use.

@eugene-s-nesdev
Copy link
Author

I've generated NSFs from FTM-file (look at archive) manually, it's NTSC headered.

@Gumball2415
Copy link
Collaborator

Gumball2415 commented Nov 19, 2023

plays same tempo on NTSC/PAL/Dendy (Mesen)

can you also clarify on this? on my build of Mesen2, the tempo and pitch slows down as expected.
are you referring to the compiled ROMs, or the compiled NSFs?

@Gumball2415
Copy link
Collaborator

... i see the problem with NSF export on PAL

image

see issue #223 for details.

@eugene-s-nesdev
Copy link
Author

eugene-s-nesdev commented Nov 19, 2023

can you also clarify on this? on my build of Mesen2, the tempo and pitch slows down as expected.
are you referring to the compiled ROMs, or the compiled NSFs?

I have lastest Mesen2 autobuild.
Compiled NES ROMs plays right way (slowing down pitch/tempo at PAL and Dendy, and different DPCM-LUTs in true-PAL)
Compiled NSFs plays same tempo in all 3 regions, and it looks like bug.
Classic versions of Famitracker and 0cc-Famitracker generates NSF "right" way

@eugene-s-nesdev
Copy link
Author

punesemu/puNES#346
puNES crackling issues

@Gumball2415
Copy link
Collaborator

Gumball2415 commented Nov 19, 2023

yes, it's an issue with the PAL play rate not being set correctly, as seen in #223.
any emulator implementing a Dendy NSF player follows this:

If the Dendy speed is omitted, any Dendy playback should use the PAL speed. (If the PAL speed is omitted, its default rate should be used.) Use with the regn chunk to enable Dendy playback.
https://www.nesdev.org/wiki/NSFe#RATE

This means that PAL and Dendy NSFs play at the erroneous 60Hz rate that Dn-FT exports.

This is a planned fix in PR #214.

@Gumball2415
Copy link
Collaborator

as for puNES, i don't think it's within Dn-FT's jurisdiction to fix an external emulator's implementation.

@Gumball2415 Gumball2415 linked a pull request Nov 19, 2023 that will close this issue
@eugene-s-nesdev
Copy link
Author

eugene-s-nesdev commented Nov 19, 2023

This is a planned fix in PR #214

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants