Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] FDS modulator overflow in NSF export #65

Closed
galap-1 opened this issue May 8, 2021 · 0 comments · Fixed by #156
Closed

[bug] FDS modulator overflow in NSF export #65

galap-1 opened this issue May 8, 2021 · 0 comments · Fixed by #156
Labels
bug Something isn't working

Comments

@galap-1
Copy link

galap-1 commented May 8, 2021

In the tracker, when using the automatic FM effect would produce a modulation rate over the maximum i.e. greater than $4806 = $FF and &4807 = $0F, they just get set to the maximum of $FF and $0F respectively, When exporting to NSF, however, the values overflow and wrap around to lower, incorrect values. This bug has been present since 0cc, but I figured that I'd mention it here again. I've attached 0cc and NSF files that succinctly demonstrate the bug.
fds.bug.zip

@Gumball2415 Gumball2415 added the bug Something isn't working label Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants