Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

When patching nodeos binaries the version number needs to change #4315

Closed
matthewdarwin opened this issue Jun 25, 2018 · 4 comments
Closed

Comments

@matthewdarwin
Copy link

Last week the nodeos software version 1.0.5 was patched due to some issue. This was discussed between the top 21 BPs and B1. However, during that process the version number was not changed (as reported in "get info"). It is hard to confirm which nodes have applied the patch and which ones not.

Suggest that all future patches modify the version number in some way. (eg 1.0.5.1)

@matthewdarwin
Copy link
Author

I'm trying to report on what versions people have. Current situation is difficult. https://validate.eosnation.io/report-versions.txt

@njappboy
Copy link

njappboy commented Jun 25, 2018

@matthewdarwin current situation allows commit hash resolution.

My current environment is running the latest docker hub eosio/eos image and v1/chain/get_info api properly returns the server_version

{
   "server_version": "79651199",
   ...
}

i.e. v1.0.6 tag commit hash 79651199
i.e. v1.0.5 tag commit hash c9b7a247
i.e. v1.0.5 (c9b7a24 parent) plus BP constitution commit hash db031363

@jgiszczak
Copy link
Contributor

Provided with #5005 released in v1.2.0.

@matthewdarwin
Copy link
Author

I know the current situation allows a commit hash. I am suggesting this way of doing things is insufficient and an additional manually updated field should be available. The field is only updated when a patch is created. so then "git apply patchfilename ..." will update it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants