Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it a problem to use a CROP surface dataset for FATES? #1948

Closed
ekluzek opened this issue Feb 1, 2023 · 2 comments
Closed

Is it a problem to use a CROP surface dataset for FATES? #1948

ekluzek opened this issue Feb 1, 2023 · 2 comments
Labels
investigation Needs to be verified and more investigation into what's going on.

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Feb 1, 2023

I thought because of #1505 that we couldn't use 78pft surface datasets for FATES. But, in ctsm5.1.dev116, I did just that for the 1x1_brazil site, and yet my testing and follow up testing for FATES by @adrifoster for ctsm5.1.dev117 showed that 1x1_brazil FATES tests seem to pass.

I think this either means that something is wrong in the setup for these cases. Or that it just means that reduced complexity modes (like FATES-SP) wouldn't work. Or that we aren't testing in a way that we'd see it fail (like running in DEBUG mode or something).

@ekluzek ekluzek added the investigation Needs to be verified and more investigation into what's going on. label Feb 1, 2023
@ekluzek ekluzek self-assigned this Feb 1, 2023
@rgknox
Copy link
Collaborator

rgknox commented Feb 1, 2023

FATES without reduced complexity (fixed biogeography) should not use any of the patch level data in the surface file, so it shouldn't matter how the PFTs are setup, or if they are natveg or crop. I'm not surprised by the results, and would had expected that test to pass with the 78 pft surface file.

@samsrabin
Copy link
Collaborator

Closing as a child of #1505.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigation Needs to be verified and more investigation into what's going on.
Projects
Status: Done
Development

No branches or pull requests

3 participants