-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and move all cond*_
functions
#181
Comments
@yijianzeng For each function below, please add one line explanation and suggest a better name in this issue, thanks
|
Ref: Scanlon, B. R. (2000), Soil gas movement in unsaturated systems, in Handbook of Soil Science, edited by M. E. Sumner, pp. A277– A319, CRC Press, Boca Raton, Fla. Zeng, Y., Su, Z., Wan, L. and Wen, J.: Numerical analysis of air-water-heat flow in unsaturated soil: Is it necessary to consider airflow in land surface models?, J. Geophys. Res. Atmos., 116(D20), 20107, doi:10.1029/2011JD015835, 2011.
van Genuchten, M. T. (1980), A closed-form equation for predicting the hydraulic conductivity of unsaturated soils, Soil Sci. Soc. Am. J., 44, 892–898
Ref: Saito, H., J. Šimůnek, and B. P. Mohanty (2006), Numerical analysis of coupled water, vapor, and heat transport in the vadose zone, Vadose Zone J., 5(2), 784– 800.
Ref: Chung, S. O., and R. Horton (1987), Soil heat and water flow with a partial surface mulch, Water Resour. Res., 23(12), 2175– 2186,
Zeng, Y., Su, Z., Wan, L. and Wen, J.: Numerical analysis of air-water-heat flow in unsaturated soil: Is it necessary to consider airflow in land surface models?, J. Geophys. Res. Atmos., 116(D20), 20107, doi:10.1029/2011JD015835, 2011. Yu, L., Zeng, Y. and Su, Z.: STEMMUS-UEB v1.0.0: integrated modeling of snowpack and soil water and energy transfer with three complexity levels of soil physical processes, Geosci. Model Dev, 14, 7345–7376, doi:10.5194/gmd-14-7345-2021, 2021.
|
@yijianzeng While refactoring
|
@yijianzeng please have a look at the questions above. |
Hi, Sarah, this film flow can improve the numerical convergence, since this is linked to soil water characteristic curve. Although it is not used in the current STEMMUS-SCOPE, this is an important part to account for freezing/thawing, which is to be activated later on. |
Hi Sarah, 'Phi_s' and 'Lamda' are parameters used by Clapp-Hornberger soil hydraulic model, see (Yu, Zeng, et al. JGR 2018). Although in STEMMUS-SCOPE, we used VG model, it is still making sense to keep Clapp-Hornberger model for future applications. |
Hi Sarah, 'Theta_II' is soil ice content, and 'Theta_LL' is liquid water content, 'Theta_UU' is the total water content before soil freezing. The 'Theta_UU' is set as saturation. This is also linked to (Yu, Zeng, et al. JGR 2018). |
It is indeed currently not used (e.g., mute the temperature dependence), but we should keep it for future extensions. |
This is used to calculate Heat Capacity and Thermal Conductivity. Perhaps renamed as 'SoilThermalProperites'. |
Hi Sarah, this is used by Lianyu to account for extremely dry condition, it is ok to keep them. |
Hi Yijian, the issue here is the circular calculation. Do you mean this procedure is correct? |
The issue here is that those equations are exactly the same except for using |
Hi Sarah, this procedure is correct in my check of this code block. The main confusion could come from many conditional statements. But the physics it represents reads fine to me. |
Yes Sarah, these equations are physically meaningful, it is used to account for extremely dry condition, and expect to improve numerical convergency. |
No description provided.
The text was updated successfully, but these errors were encountered: