Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat (unmatched-skip) warnings as errors #480

Closed
MarijnS95 opened this issue Nov 8, 2022 · 3 comments
Closed

Treat (unmatched-skip) warnings as errors #480

MarijnS95 opened this issue Nov 8, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@MarijnS95
Copy link

Is your feature request related to a problem? Please describe.

Whenever we remove a great deal of (transitive) crates, or upgrade our crate dependencies, there's a chance some (possibly duplicate) crate disappears while being specified in deny.toml. cargo-deny currently emits a useful warning for that such as warning[license-exception-not-encountered]: license exception was not encountered or warning[unmatched-skip]: skipped crate 'xxx = y.y.y' was not encountered. However, there's currently no way make cargo-deny fail in our CI to complain about this overspecification, as we can now finally drop some skip/exception from our deny.toml.

Describe the solution you'd like
Treating these warnings as errors, so that our CI fails until the now-unused skip declaration has been removed.

Describe alternatives you've considered
None.

Additional context
None.

@MarijnS95 MarijnS95 added the enhancement New feature or request label Nov 8, 2022
@Jake-Shadle
Copy link
Member

@MarijnS95
Copy link
Author

@Jake-Shadle Ah perfect, thanks! Looks like -D warnings catches all warnings, that's amazing!

Didn't know it was a config option on check rather than on cargo deny (just like how --workspace has to be passed before check, since it's a subcommand).

@Jake-Shadle
Copy link
Member

Other commands don't have diagnostics, only check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants