Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tabs] Tab content scrollbar is cut off when tabs have a set height #8091

Closed
2 of 5 tasks
mpayson opened this issue Oct 31, 2023 · 3 comments
Closed
2 of 5 tasks

[tabs] Tab content scrollbar is cut off when tabs have a set height #8091

mpayson opened this issue Oct 31, 2023 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-tab Issues that pertain to calcite-tab components calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2023 December Pri...

Comments

@mpayson
Copy link

mpayson commented Oct 31, 2023 •
edited
Loading

Check existing issues

Actual Behavior

If the tabs component has a fixed height and the tab content needs to scroll, the scrollbar gets cut off, and the down arrow in some scroll bars is not clickable

Screenshot 2023-10-31 at 8 08 16 AM

Expected Behavior

The whole scroll bar is displayed

Reproduction Sample

https://codepen.io/mpayson/pen/abXZoqX

Reproduction Steps

  1. Open the code pen
  2. If scroll bars are always visible on your machine, see the scrollbar is cut off
  3. If scroll bars are not always visible, try scrolling the tab content and see the scrollbar is cut off

Reproduction Version

1.1.0

Relevant Info

No response

Regression?

No response

Priority impact

p3 - want for upcoming milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Online
@mpayson mpayson added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Oct 31, 2023
@github-actions github-actions bot added ArcGIS Online Issues logged by ArcGIS Online team members. p3 - want for upcoming milestone calcite-components Issues specific to the @esri/calcite-components package. labels Oct 31, 2023
@mpayson mpayson changed the title [tabs] Tab content scrollbar is cut off when tabs have a fixed height [tabs] Tab content scrollbar is cut off when tabs have a set height Oct 31, 2023
@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library estimate - 2 Small fix or update, may require updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Nov 27, 2023
@mpayson mpayson mentioned this issue Dec 12, 2023
Closed
5 tasks
@eriklharper eriklharper added the c-tab Issues that pertain to calcite-tab components label Dec 13, 2023
@eriklharper
Copy link
Contributor

I verified this on calcite next (latest main) and #8399 appears to have fixed this issue as well. I tested Chrome, Firefox and Safari latest on macos and they all show the scrollbar in its entirety. I would screenshot the result I'm seeing if I could, but doesn't seem modern browser versions let you persist the scrollbar in scrollable regions anymore.

@eriklharper eriklharper added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. labels Dec 13, 2023
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Dec 13, 2023

🍫 Verified, basically the same info that Erik mentions above.

@DitwanP DitwanP closed this as completed Dec 13, 2023
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 27, 2023
@geospatialem geospatialem added this to the 2023 December Priorities milestone Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-tab Issues that pertain to calcite-tab components calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2023 December Priorities
Development

No branches or pull requests
4 participants
@eriklharper @geospatialem @mpayson @DitwanP