Skip to content
This repository was archived by the owner on Dec 20, 2024. It is now read-only.

Collections - 24px icon alignment #43

Closed
asangma opened this issue Mar 7, 2019 · 8 comments
Closed

Collections - 24px icon alignment #43

asangma opened this issue Mar 7, 2019 · 8 comments
Assignees

Comments

@asangma
Copy link

asangma commented Mar 7, 2019

image

Would it be optically problematic to have the upper right part of collection-24.svg at the same place as it is in collection-24-f.svg?
image

@asangma
Copy link
Author

asangma commented Mar 7, 2019

@paulcpederson @KatelynSeitz @johnmgriffith

Looks like I'm no longer able to assign issues.
(゜-゜)

@SkyeSeitz
Copy link
Contributor

Good catch. Let's adjust the 24 outlined to match the filled.

Not sure why you can't assign issues at the moment...🤔🤔🤔
Can I still close out an issue if I'm not assigned to it?

If so, we will include this change in the next release and close out the issue then.

@asangma
Copy link
Author

asangma commented Mar 7, 2019

Thanks @KatelynSeitz .
I'm still able to close issues.

@asangma
Copy link
Author

asangma commented Mar 7, 2019

Sorry I didn't notice this before (I've only been working with 16 and 24 icons), but collection-32.svg might also need a review. Let me know if you'd like an issue for that or if the difference between the outlined and filled on that icon is needed for optical reasons.

@asangma
Copy link
Author

asangma commented Mar 7, 2019

collection-32

@griffgriffindor
Copy link
Contributor

Thanks for pointing that out. I'll update 1.6.4 with the new collection-32 icon too

@griffgriffindor
Copy link
Contributor

Both of these icons were resolved in release v1.6.4, and are now merged to master. Closing this issue.

@asangma
Copy link
Author

asangma commented Mar 8, 2019

Thanks @johnmgriffith!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants