Notch is off-centered

[Capybara121]

I'm attempting to set up a split bar design using fillers positioned at positions q and e, and am noticing that the notch appears to be off-centered. The two sides of the bar reach out to different distances away from the notch.

The left bracket measures 1267 pixels wide, while the right bracket measures 1269 pixels wide.

[PhrantiK]

You have notch_width defined twice in your bar config, one value with an odd number.

[Capybara121]

You have notch_width defined twice in your bar config, one value with an odd number.

Thanks, didn't notice that. That being said, the issue still persists as the newest value is an even number, which should have overwritten the odd number notch. Also, the behaviour for an odd-pixel notch should be that there is a one pixel difference, right?

[FelixKratz]

It is probably an off-by-one error I made here:

SketchyBar/src/bar.c

Lines 246 to 250 in c713afe

	uint32_t bar_center_right_first_item_x = (bar->window.frame.size.width
	+ notch_width) / 2 - 1;
	uint32_t bar_center_left_first_item_x = (bar->window.frame.size.width
	- notch_width) / 2 - 1;

Feel free to play with these two lines till it is symmetric and post a PR.