Skip to content

Commit 9e08718

Browse files
committed
Merge branch 'master' into dsp-cpp
2 parents fe98e60 + e57360d commit 9e08718

File tree

3 files changed

+11
-8
lines changed

3 files changed

+11
-8
lines changed

src/synth/fluid_voice.c

+4-6
Original file line numberDiff line numberDiff line change
@@ -1399,14 +1399,12 @@ fluid_voice_kill_excl(fluid_voice_t *voice)
13991399
fluid_voice_gen_set(voice, GEN_EXCLUSIVECLASS, 0);
14001400

14011401
/* Speed up the volume envelope */
1402-
/* The value was found through listening tests with hi-hat samples. */
1403-
fluid_voice_gen_set(voice, GEN_VOLENVRELEASE, -200);
1402+
/* The previously-used value of "-200" was found through listening tests
1403+
with hi-hat samples. This was changed to "-2000" after "-200" was shown
1404+
to cause too long cut times in most cases. */
1405+
fluid_voice_gen_set(voice, GEN_VOLENVRELEASE, -2000);
14041406
fluid_voice_update_param(voice, GEN_VOLENVRELEASE);
14051407

1406-
/* Speed up the modulation envelope */
1407-
fluid_voice_gen_set(voice, GEN_MODENVRELEASE, -200);
1408-
fluid_voice_update_param(voice, GEN_MODENVRELEASE);
1409-
14101408
at_tick = fluid_channel_get_min_note_length_ticks(voice->channel);
14111409
UPDATE_RVOICE_I1(fluid_rvoice_noteoff, at_tick);
14121410

test/CMakeLists.txt

+6-1
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,12 @@ else()
186186

187187
add_custom_target(renderExcl
188188
COMMAND fluidsynth -R 0 -C 0 -g 1.4 -F "${EXCL_RENDER_DIR}/exclusive class cutoff speed.${FEXT}" "exclusive class cutoff speed.mid" "exclusive class cutoff speed.sf2"
189-
COMMENT "Rendering Christian Collins' exclusive class cutoff test"
189+
COMMAND fluidsynth -R 0 -C 0 -g 1.4 -F "${EXCL_RENDER_DIR}/MIDInotecut.${FEXT}" "MIDInotecut.mid" ${GENERAL_USER_GS2}
190+
COMMAND fluidsynth -R 0 -C 0 -g 1.4 -F "${EXCL_RENDER_DIR}/percussion note cutoff.${FEXT}" "percussion note cutoff.mid" ${GENERAL_USER_GS2}
191+
COMMAND fluidsynth -R 0 -C 0 -g 1.4 -F "${EXCL_RENDER_DIR}/percussion-test.${FEXT}" "percussion-test.mid" ${GENERAL_USER_GS2}
192+
COMMAND fluidsynth -R 0 -C 0 -g 0.6 -F "${EXCL_RENDER_DIR}/e1m1_GeneralUser2.${FEXT}" "e1m1.mid" ${GENERAL_USER_GS2}
193+
COMMAND fluidsynth -R 0 -C 0 -g 0.6 -F "${EXCL_RENDER_DIR}/e1m1_gzdoom.${FEXT}" "e1m1.mid" "../sf2/gzdoom.sf2"
194+
COMMENT "Rendering exclusive class cutoff tests"
190195
DEPENDS fluidsynth create_iir_dir
191196
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/manual/exclusive_class/
192197
VERBATIM

0 commit comments

Comments
 (0)