FM claims that it needs root to delete a file

[mimi89999]

Checklist

• I can reproduce the bug with the latest version given here.
• I made sure that there are no existing issues - open or closed - to which I could contribute my information.
• I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
• I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
• I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
• This issue contains only one bug.
• I have read and understood the contribution guidelines.

Affected app version

1.0.1

Affected Android/Custom ROM version

Android 15

Affected device model

Sony Xperia 5 V

How did you install the app?

F-Droid / IzzyOnDroid

Steps to reproduce the bug

1. Go to the Download folder
2. Select a file
3. Click on the trash bin icon and confirm deletion

Expected behavior

The file should get deleted

Actual behavior

FM claim that this operation only works on rooted devices

Screenshots/Screen recordings

No response

Additional information

Other file manager like https://f-droid.org/packages/me.zhanghai.android.files/ are able to delete files in that location.

[naveensingh]

• Does it happen always or randomly?
• Where is this Download folder located? Is it the default/internal storage or an SD Card?
• Do you have any screenshots/recordings for this?

[mimi89999]

It happens always. The reported file path is /sdcard/Download

[naveensingh]

One more:

• How was this file created? Was it downloaded using some browser or was it transferred from some other device?

[mimi89999]

The file was downloaded with Firefox

[naveensingh]

Do you have any screenshots/recordings for this?

Would be great if you could share a screen recording.

[mimi89999]

There is not much going on. Just a toast at the bottom of the screen with the error message appearing.

[mimi89999]

5db3bb5f-c3ee-4e0a-a2d1-285a3fbe92d1.mp4

[naveensingh]

This function is probably returning true when it shouldn't meaning the SD Card path is being treated as a system directory by the app.

May or may not be related to #82 but this does seem like a device specific issue.

[mimi89999]

Maybe the logic could be improved to better handle such cases? What would happen if the app attempted to delete the file even if it was not allowed to?

I can build the app and add some logging if that can help fix the issue.

[naveensingh]

Maybe the logic could be improved to better handle such cases? What would happen if the app attempted to delete the file even if it was not allowed to?

Yes. A SecurityException would be thrown, probably.

I can build the app and add some logging if that can help fix the issue.

More investigation is due but the code that "finds" the SD card path is located inside the commons library: https://github.com/FossifyOrg/Commons/blob/3dd1f7f33ec9d7001a6a81584917971bdf44f50c/commons/src/main/kotlin/org/fossify/commons/extensions/Context-storage.kt#L37

For a start, you may try to log the config.sdCardPath value and compare it with the path that is shown in the file properties dialog.

[mimi89999]

I built the latest version from source and file deletion just works there.

[naveensingh]

I built the latest version from source and file deletion just works there.

That is strange. Can you try again with a clean install of the official version?

[mimi89999]

I uninstalled and installed the app. Deleting files now also works.

[naveensingh]

Maybe a device or SD Card issue. Closing for now, will reopen if it's reported again.

[mimi89999]

It seems that my device is haunted 👻