Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build Commons as subproject #144

Closed
7 tasks done
mimi89999 opened this issue Mar 11, 2025 · 4 comments · Fixed by #146
Closed
7 tasks done

Can't build Commons as subproject #144

mimi89999 opened this issue Mar 11, 2025 · 4 comments · Fixed by #146
Assignees
Labels
bug Something is not working

Comments

@mimi89999
Copy link

mimi89999 commented Mar 11, 2025

Checklist

  • I can reproduce the bug with the latest version given here.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected app version

0aa2786

Affected Android/Custom ROM version

N/A

Affected device model

N/A

How did you install the app?

Built from source

Steps to reproduce the bug

Apply:

diff --git a/app/build.gradle.kts b/app/build.gradle.kts
index 15aca465..36b277f0 100644
--- a/app/build.gradle.kts
+++ b/app/build.gradle.kts
@@ -101,7 +101,7 @@ detekt {
 }
 
 dependencies {
-    implementation(libs.fossify.commons)
+    implementation("org.fossify:commons")
     implementation(libs.androidx.documentfile)
     implementation(libs.androidx.swiperefreshlayout)
     implementation(libs.roottools)
diff --git a/settings.gradle.kts b/settings.gradle.kts
index 45478cbe..04c73261 100644
--- a/settings.gradle.kts
+++ b/settings.gradle.kts
@@ -14,3 +14,4 @@ dependencyResolutionManagement {
     }
 }
 include(":app")
+includeBuild("../Commons")

And try to build

Expected behavior

Builds

Actual behavior

* What went wrong:
An exception occurred applying plugin request [id: 'com.android.library', version: '8.7.3']
> Failed to apply plugin 'com.android.internal.version-check'.
   > Minimum supported Gradle version is 8.9. Current version is 8.4. If using the gradle wrapper, try editing the distributionUrl in /home/michel/git/Commons/gradle/wrapper/gradle-wrapper.properties to gradle-8.9-all.zip

Screenshots/Screen recordings

No response

Additional information

No response

@mimi89999 mimi89999 added bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Mar 11, 2025
@naveensingh naveensingh removed the needs triage Issue is not yet ready for PR authors to take up label Mar 11, 2025
@mimi89999
Copy link
Author

The suggestion is a bit misleading. It's the Gradle wrapper in FM that needs to be updated.

@naveensingh
Copy link
Member

Yes, compose builds require identical AGP versions.

@naveensingh
Copy link
Member

#146

You may build from that branch for now. If you get any errors during build, just comment out lines causing the error.

Can't build Commons as subproject

This will now be an issue in all Fossify apps so please do not open additional issues for that. Build configuration is updated when the apps are updated.

@mimi89999
Copy link
Author

Thanks. After commenting out four lines, I was able to build the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants