Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery not opening/available when previewing photos from LineageOS Camera (Aperture) #411

Open
7 tasks done
ElementW opened this issue Mar 2, 2025 · 3 comments
Open
7 tasks done
Assignees
Labels
enhancement New feature or request

Comments

@ElementW
Copy link

ElementW commented Mar 2, 2025

Checklist

  • I can reproduce the bug with the latest version given here.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected app version

1.2.1

Affected Android/Custom ROM version

Android 13 / LineageOS 20

Affected device model

Pixel 4a 5G

How did you install the app?

F-Droid / IzzyOnDroid

Steps to reproduce the bug

  1. Use LineageOS' default camera app "Aperture"
  2. Take a picture
  3. Tap the picture preview

Expected behavior

Gallery opens to preview picture, or is present in the app picker that opens up

Actual behavior

Gallery doesn't open/is absent from the intent-handling app picker

Screenshots/Screen recordings

No response

Additional information

Aperture launches a MediaStore.ACTION_REVIEW intent when on Android 10 and above, which translates to android.provider.action.REVIEW, that is notably absent from AndroidManifest.xml or the codebase at large, hence the app not launching when it should.
Probably should be handled just like you do with com.android.camera.action.REVIEW.

@ElementW ElementW added bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Mar 2, 2025
@Aga-C Aga-C added enhancement New feature or request and removed bug Something is not working labels Mar 2, 2025
@naveensingh
Copy link
Member

naveensingh commented Mar 2, 2025

As per the linked Aperture code, it should switch to Intent.ACTION_VIEW when MediaStore.ACTION_REVIEW fails to find any matching activities. As a result, Fossify Gallery only shows up when there's no other app that can handle MediaStore.ACTION_REVIEW.

EDIT: Removed question.

@naveensingh naveensingh added bug Something is not working question Further information is requested enhancement New feature or request and removed enhancement New feature or request bug Something is not working labels Mar 2, 2025
@Aga-C Aga-C added the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Mar 2, 2025
@naveensingh
Copy link
Member

Related: deckerst/aves#1052

@naveensingh naveensingh removed question Further information is requested waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. needs triage Issue is not yet ready for PR authors to take up labels Mar 2, 2025
@ElementW
Copy link
Author

ElementW commented Mar 2, 2025

I do not have another gallery app that handles the intent, but I do have App Manager and its intent interceptor listening to everything; that's what gets opened instead.

That said, presence of another gallery/handler app is no excuse to not implement handling in Fossify Gallery, as it's otherwise expected you would be able to open it for previews in any app launching a android.provider.action.REVIEW intent, be they executing a fallback to Intent.ACTION_VIEW or not.

@naveensingh naveensingh self-assigned this Mar 3, 2025
@ElementW ElementW changed the title Gallery not opening when previewing photos from LineageOS Camera (Aperture) Gallery not opening/available when previewing photos from LineageOS Camera (Aperture) Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants