Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget resizing sometimes starts at incorrect position #108

Open
7 tasks done
FliegendeWurst opened this issue Mar 3, 2025 · 0 comments
Open
7 tasks done

Widget resizing sometimes starts at incorrect position #108

FliegendeWurst opened this issue Mar 3, 2025 · 0 comments
Labels
bug Something is not working

Comments

@FliegendeWurst
Copy link
Contributor

Checklist

  • I can reproduce the bug with the latest version given here.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected app version

latest commit 8c3a74a, and 1.0.1 release

Affected Android/Custom ROM version

Android 12

Affected device model

Nokia 5.4

How did you install the app?

Built from source

Steps to reproduce the bug

  1. Add a resizable widget to the homescreen, and resize it to 3x3
  2. Long press on widget, select resize
  3. Move left drag point one cell to the right
  4. Exit resize view
  5. Resize same widget
  6. Move left drag point one cell to the left
  7. Exit resize view
  8. Resize same widget

Expected behavior

Resizing should work as expected. No unexpected jumps in widget position.

Actual behavior

After step 2, 5 or 8 the widget jumps one cell to the left or right (seemingly dependent on some previous state).

Screenshots/Screen recordings

I can record the issue if you cannot reproduce it.

Additional information

The resizable widget I reproduced the issue with is from my own app, but it does little more than the example widget that was automatically generated.

The issue can be fixed by adding the following to binding.resizeFrame.onResizeListener in HomeScreenGrid, but it seems like a bit of a hack:

gridItems.filterVisibleOnCurrentPageOnly().filter { it.id == item.id }.forEach { gridItem ->
    gridItem.left = item.left
    gridItem.top = item.top
    gridItem.right = item.right
    gridItem.bottom = item.bottom
}
@FliegendeWurst FliegendeWurst added bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Mar 3, 2025
@Aga-C Aga-C removed the needs triage Issue is not yet ready for PR authors to take up label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
Development

No branches or pull requests

2 participants