-Wstringop-truncation warnings observed in core_http_client.c

[SKZahidBasha-Silabs]

Warnings related to strncpy are observed in the core_http_client.c file at the below lines of code. Attached the warnings snapshot :

Line 1:
( void ) strncpy( pBufferCur,
HTTP_HEADER_FIELD_SEPARATOR,
HTTP_HEADER_FIELD_SEPARATOR_LEN );

Line 2:
( void ) strncpy( pBufferCur,
HTTP_HEADER_END_INDICATOR,
HTTP_HEADER_END_INDICATOR_LEN );

Line 3:
( void ) strncpy( pBufferCur,
HTTP_HEADER_LINE_SEPARATOR,
HTTP_HEADER_LINE_SEPARATOR_LEN );

[paulbartell]

@SKZahidBasha-Silabs : These warnings can be safely ignored since the target buffer is not necessarily a null terminated string.

You can mask these warnings locally with something like:

#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wstringop-truncation"
strncpy( ... )
#pragma GCC diagnostic pop

[alfred2g]

@paulbartell, would be better if we use memcpy instead (since not null terminated) ?

[RichardBarry]

To help decide on the action to take - the code needs to compile without warnings with the -Wall and -Wextra GCC command line options.

[SKZahidBasha-Silabs]

Is it better to change strncpy() to memcpy() (or) use the pragmas as suggested above. I see memcpy() being used at some places in the same file.

[alfred2g]

Better to change the strncpy to memcpy, GCC pragmas are not portable

[SKZahidBasha-Silabs]

@alfred2g / @paulbartell / @RichardBarry so the fix for this would be to convert strncpy to memcpy, is that right? Shall we conclude on the fix approach please?

[alfred2g]

@SKZahidBasha-Silabs, yeah that should be the fix, do you want to push a pull request, or you prefer if we do it ?

[SKZahidBasha-Silabs]

@alfred2g I guess you pushing the fix would be nicer for future tracking. Thanks for the confirmation on the approach!

[alfred2g]

#134

[alfred2g]

Code is merged, closing the issue

[SKZahidBasha-Silabs]

Thanks, @alfred2g for fixing this!